fix wrong citation (78 instead of 73) #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjeffery
approved these changes
Mar 5, 2025
|
Congrats your your first msprime PR! |
|
Looks like the doc build is broken - I'll fix in another PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2341 +/- ##
=======================================
Coverage 90.93% 90.93%
=======================================
Files 20 20
Lines 12018 12018
Branches 2316 2316
=======================================
Hits 10929 10929
Misses 602 602
Partials 487 487
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
benjeffery
force-pushed
the
Fix-wrong-smm-citation
branch
from
a66b56c to
fc97e38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that's the cited paper: https://doi.org/10.1073/pnas.75.6.2868
It is cited correctly in the docstring of the python method