Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show more of filename #201

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Show more of filename #201

merged 1 commit into from
Oct 16, 2024

Conversation

benjeffery
Copy link
Member

Now that we have fewer pages a very quick fix to #200 is to just show more of the filename - @duncanMR will this do? Or do you think a larger change is needed?

Copy link

Automated Screenshots

These screenshots are automatically updated as the PR changes.

Click to view screenshots

out_edges.png

out_edges.png

out_mutations.png

out_mutations.png

out_nodes.png

out_nodes.png

github-actions bot pushed a commit that referenced this pull request Oct 15, 2024
@coveralls
Copy link

coveralls commented Oct 15, 2024

Pull Request Test Coverage Report for Build 11349541467

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 82.374%

Totals Coverage Status
Change from base Build 11329813735: 0.02%
Covered Lines: 687
Relevant Lines: 834

💛 - Coveralls

@duncanMR
Copy link
Contributor

Yes that works fine for me; I just tried it out below in a half screen-width window. It does push the tabs quite far to the right, but I can't think of a way around that. I don't think trying to put the title above or below the tabs would look good.

image

@jeromekelleher
Copy link
Member

I'd like to see the filename on the overview page too, we will have very long filenames and the most significant stuff tends to be at the end. It's just another row in the output pane, right?

@benjeffery
Copy link
Member Author

Great idea - I've added the file path to the overview.

github-actions bot pushed a commit that referenced this pull request Oct 15, 2024
github-actions bot pushed a commit that referenced this pull request Oct 15, 2024
@benjeffery benjeffery merged commit 2faab76 into tskit-dev:main Oct 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants