Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic pages #220

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Dynamic pages #220

merged 2 commits into from
Nov 13, 2024

Conversation

benjeffery
Copy link
Member

WIP Work on #150
The trees page now resizes the plots dynamically, should be portable to the other pages.

Copy link

Automated Screenshots

These screenshots are automatically updated as the PR changes.

Click to view screenshots

edges.png

edges.png

mutations-popup.png

mutations-popup.png

mutations.png

mutations.png

nodes.png

nodes.png

out_edges.png

out_edges.png

out_mutations.png

out_mutations.png

out_nodes.png

out_nodes.png

overview.png

overview.png

tables.png

tables.png

trees.png

trees.png

github-actions bot pushed a commit that referenced this pull request Oct 25, 2024
Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the right approach to me! Wonderful if we can get this niggle sorted.

github-actions bot pushed a commit that referenced this pull request Nov 12, 2024
@benjeffery benjeffery changed the title Dynamic size tree page Dynamic pages Nov 13, 2024
github-actions bot pushed a commit that referenced this pull request Nov 13, 2024
github-actions bot pushed a commit that referenced this pull request Nov 13, 2024
@benjeffery benjeffery marked this pull request as ready for review November 13, 2024 13:41
@benjeffery
Copy link
Member Author

I've brought this across to edges, trees and nodes, but failed at mutations. I can get some of the elements to resize, but the bottom one loses it's linking to the x axis.

github-actions bot pushed a commit that referenced this pull request Nov 13, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11818571942

Details

  • 27 of 27 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 89.266%

Totals Coverage Status
Change from base Build 11800737612: 0.2%
Covered Lines: 790
Relevant Lines: 885

💛 - Coveralls

@jeromekelleher jeromekelleher merged commit ae19bcd into tskit-dev:main Nov 13, 2024
6 checks passed
@benjeffery benjeffery deleted the dynamic_size branch November 13, 2024 15:48
@benjeffery benjeffery mentioned this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants