Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent parameter naming for removing flanks vs tsinfer #398

Open
hyanwong opened this issue Jun 5, 2024 · 0 comments
Open

Inconsistent parameter naming for removing flanks vs tsinfer #398

hyanwong opened this issue Jun 5, 2024 · 0 comments

Comments

@hyanwong
Copy link
Member

hyanwong commented Jun 5, 2024

We use the parameter erase_flanks in tsinfer, and remove_telomeres in tsdate:

tsinfer.post_process(ts, erase_flanks=False)
 tsdate.preprocess_ts(ts, remove_telomeres=False)

I guess it would be helpful to make them the same and deprecate one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant