-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flesh out metadata doc schema example #2146
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2146 +/- ##
=======================================
Coverage 89.72% 89.72%
=======================================
Files 29 29
Lines 31567 31573 +6
Branches 6113 6115 +2
=======================================
+ Hits 28322 28328 +6
Misses 1853 1853
Partials 1392 1392
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd choose a different example in case people think this is the recommended route for location info.
Thanks @hyanwong, looks good modulo JK's comments. |
bb2ebf4
to
e1cb928
Compare
OK, changed to height and age. I left a default for both there, as this is not an obvious thing to be able to do, so having an example is helpful, I think, even though the two values are basically independent. |
8362d07
to
e1e90ea
Compare
This is now ready for merging, IMO, @benjeffery |
@Mergifyio rebase |
✅ Nothing to do for rebase action |
Yeesh 32bit tests are failing hard. Will investigate. |
@Mergifyio rebase |
✅ Branch has been successfully rebased |
e1e90ea
to
0b76c1f
Compare
0193d17
to
f650f26
Compare
f650f26
to
051b324
Compare
As discussed with @benjeffery