Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pbs function to tree.py #2748

Closed
wants to merge 2 commits into from
Closed

add pbs function to tree.py #2748

wants to merge 2 commits into from

Conversation

atongsa
Copy link

@atongsa atongsa commented Apr 28, 2023

Description

add a PBS function to test population local adaptation;
solve the issue #2717 ;

Fixes #(2717) <- Putting the issue number here will auto-close the issue when this PR is merged

PR Checklist:

  • Tests that fully cover new/changed functionality.
  • Documentation including tutorial content if appropriate.
  • Changelogs, if there are API changes.

@benjeffery
Copy link
Member

Thanks @atongsa!
It looks like your PR has a couple of extra files (the ones in tmp) can you remove those?

Also do you want some pointers on adding a test for this new function, or are you happy to try? There are some pointers at https://tskit.dev/tskit/docs/stable/development.html#tests

@atongsa
Copy link
Author

atongsa commented Apr 29, 2023

Thanks @atongsa! It looks like your PR has a couple of extra files (the ones in tmp) can you remove those?

Also do you want some pointers on adding a test for this new function, or are you happy to try? There are some pointers at https://tskit.dev/tskit/docs/stable/development.html#tests

i will try add a test

@atongsa atongsa closed this Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants