Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asdict to Dataclass #2759

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Add asdict to Dataclass #2759

merged 1 commit into from
Jul 11, 2023

Conversation

benjeffery
Copy link
Member

Fixes #2719

Copy link
Member Author

@benjeffery benjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a changelog as this is part of the public API.

@benjeffery
Copy link
Member Author

Addressed in ac7cd88

@jeromekelleher jeromekelleher added this to the Python 0.5.5 milestone Jul 7, 2023
@jeromekelleher
Copy link
Member

Can we get this one in please @benjeffery?

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #2759 (31af65c) into main (a3b095f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2759   +/-   ##
=======================================
  Coverage   89.89%   89.89%           
=======================================
  Files          30       30           
  Lines       29041    29043    +2     
  Branches     5672     5672           
=======================================
+ Hits        26105    26107    +2     
  Misses       1667     1667           
  Partials     1269     1269           
Flag Coverage Δ
c-tests 86.40% <ø> (ø)
lwt-tests 80.13% <ø> (ø)
python-c-tests 67.04% <100.00%> (+<0.01%) ⬆️
python-tests 99.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/tskit/util.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3b095f...31af65c. Read the comment docs.

@mergify mergify bot merged commit 555913c into tskit-dev:main Jul 11, 2023
21 checks passed
@mergify mergify bot removed the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Jul 11, 2023
@benjeffery benjeffery deleted the asdict branch July 11, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add asdict() to util.Dataclass
2 participants