add_pbs #2777
add_pbs #2777
Conversation
| divergences.shape = (divergences.shape[0], 1, divergences.shape[1]) | ||
| diversities.shape = (diversities.shape[0], 1, diversities.shape[1]) | ||
|
|
||
| fst = np.repeat(1.0, np.product(divergences.shape)) |
There was a problem hiding this comment.
I think it would be better just to call self.Fst( ) directly instead of copying the code.
| ) | ||
| fst.shape = orig_shape | ||
|
|
||
| def cal_pbs(arr_0): |
There was a problem hiding this comment.
I don't think we're gaining anything by separating this out into a function that is immediately called.
|
|
||
| """ | ||
|
|
||
| def pbs_func(sample_set_sizes, flattened, indexes], **kwargs): |
|
I started commenting on the code, @atongsa, but noticed a bunch of typos, e.g., Please let us know when you've got code that runs (at least, doesn't have syntax errors)? Or, ask if you have specific questions about the approach? |
|
Hi @atongsa - are you planning to come back to this work? Thanks! |
|
sorry, it is a little difficult for me, i don't understand the errors, and has no idea how to fix it, i need to read more about the funcions and docs. |
|
Closing this for now due to inactivity. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2777 +/- ##
==========================================
- Coverage 89.83% 86.24% -3.59%
==========================================
Files 30 8 -22
Lines 28624 13060 -15564
Branches 5590 2517 -3073
==========================================
- Hits 25713 11264 -14449
+ Misses 1655 991 -664
+ Partials 1256 805 -451
Flags with carried forward coverage won't be shown. Click here to find out more. |
Description
sorry i messed and delete my local branch, so the pr #2749 was closed automately;
i don't know how to reopen, so i opened a new pr;
sorry agian;
Closes #2717
PR Checklist: