Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diploid testing: merge forward-backward and viterbi testing #2798

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

astheeggeggs
Copy link
Contributor

This combines together test_genotype_matching_fb.py and test_genotype_matching_viterbi.py to avoid redundant code.

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #2798 (bcc01e5) into main (2f4c8f4) will decrease coverage by 13.30%.
The diff coverage is n/a.

❗ Current head bcc01e5 differs from pull request most recent head 09ae207. Consider uploading reports for the commit 09ae207 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2798       +/-   ##
===========================================
- Coverage   89.79%   76.49%   -13.30%     
===========================================
  Files          30       29        -1     
  Lines       29474    28322     -1152     
  Branches     5737     5308      -429     
===========================================
- Hits        26465    21666     -4799     
- Misses       1726     5341     +3615     
- Partials     1283     1315       +32     
Flag Coverage Δ
c-tests 86.24% <ø> (+0.14%) ⬆️
lwt-tests 80.13% <ø> (-0.66%) ⬇️
python-c-tests 67.12% <ø> (-0.77%) ⬇️
python-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f4c8f4...09ae207. Read the comment docs.

@jeromekelleher
Copy link
Member

I think it's worth learning how to do rebasing @astheeggeggs - the history is a mess here and it'll make your life miserable. Ben or I can take you through it if the docs here aren't clear

@jeromekelleher
Copy link
Member

Looks good, will need a rebase once #2799 lands (which brings in lshmm 0.0.5)

@jeromekelleher jeromekelleher added the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Aug 23, 2023
@jeromekelleher jeromekelleher merged commit 4f0fc78 into tskit-dev:main Aug 23, 2023
15 checks passed
@mergify mergify bot removed the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants