Remove 3.7 and update pre-commit to 3.8 #2856
Conversation
| @@ -16,7 +16,6 @@ classifiers = | |||
| Programming Language :: C | |||
| Programming Language :: Python | |||
| Programming Language :: Python :: 3 | |||
| Programming Language :: Python :: 3.7 | |||
| Programming Language :: Python :: 3.8 | |||
| Programming Language :: Python :: 3.9 | |||
| Programming Language :: Python :: 3.10 | |||
There was a problem hiding this comment.
Just checked and it was already there - just snipped off this diff.
| @@ -403,13 +403,15 @@ def draw_tree( | |||
| warnings.warn( | |||
| "tree_height_scale is deprecated; use time_scale instead", | |||
| FutureWarning, | |||
| stacklevel=4, | |||
There was a problem hiding this comment.
What's the stacklevel stuff about?
There was a problem hiding this comment.
One of the pre-commit plugins was complaining about its absence. With stacklevel the user gets more than one line of the stacktrace with a warning.
There was a problem hiding this comment.
B028: No explicit stacklevel argument found. The warn method from the warnings module uses a stacklevel of 1 by default. This will only show a stack trace for the line on which the warn method is called. It is therefore recommended to use a stacklevel of 2 or greater to provide more information to the user.
Codecov Report
@@ Coverage Diff @@
## main #2856 +/- ##
==========================================
- Coverage 89.94% 89.75% -0.20%
==========================================
Files 28 30 +2
Lines 22849 29902 +7053
Branches 4621 5803 +1182
==========================================
+ Hits 20552 26839 +6287
- Misses 1281 1755 +474
- Partials 1016 1308 +292
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Fixes #2597