-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unifying stat method desc and linking to math summary #3005
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3005 +/- ##
==========================================
+ Coverage 89.81% 89.82% +0.01%
==========================================
Files 29 29
Lines 31979 31995 +16
Branches 6190 6195 +5
==========================================
+ Hits 28721 28739 +18
+ Misses 1861 1859 -2
Partials 1397 1397
Flags with carried forward coverage won't be shown. Click here to find out more.
|
python/tskit/trees.py
Outdated
@@ -8246,6 +8249,9 @@ def genetic_relatedness( | |||
""" | |||
Computes genetic relatedness between (and within) pairs of | |||
sets of nodes from ``sample_sets``. | |||
Please see the :ref:`summary functions <sec_stats_summary_functions>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the :ref:`summary functions <sec_stats_summary_functions>` | |
See the :ref:`summary functions <sec_stats_summary_functions>` |
For consistency.
python/tskit/trees.py
Outdated
Please see the :ref:`summary functions <sec_stats_summary_functions>` | ||
section on the exact definition of the calculated statistic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't actually think the "summary function" is a good place to refer people to here. That is a definition, but it only makes sense if someone understands How It All Works. The approach we've taken in other statistics is to provide a more plain (but equivalent) definition. I think here the thing to do is to just refer to the docs for genetic_relatedness
, because this function's notion of genetic relatedness is the same as that one.
In general I like the rearrangments, but I don't think we should add "please see summary functions for a precise definition". Instead, we should make what's said there in the documentation precise enough, if it isn't already? I am pretty sure that what's there for |
@petrelharp I followed your suggestions in the last commit. I thought adding the link to computational/mathematical definition would be useful to provide concrete/mathematical detail of what is calculated. This makes things concrete, but since it's only a link, it does not overwhelm a user (I agree that simple descriptive text should be preferred). Also, you have written these math details for some stats, so adding these links exposes/leverages that part of the doc (most users will only look at function docs and won't go over the whole stats doc to find math detail). Happy to iterate. |
I was working through the stats tutorial at https://tskit.dev/tutorials/analysing_tree_sequences.html (incoming PR) and thought that linking stats/math summaries (https://tskit.dev/tskit/docs/stable/stats.html#summary-functions) to method docs would be very useful.
I also followed a style from the diversity method doc (what is the stat, then links to sample_sets, windows, ...).
@petrelharp can you have a look at this PR?