Update python changelog #3014
Merged
Update python changelog #3014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3014 +/- ##
=======================================
Coverage 89.84% 89.84%
=======================================
Files 29 29
Lines 32093 32093
Branches 6230 6230
=======================================
Hits 28833 28833
Misses 1859 1859
Partials 1401 1401
Flags with carried forward coverage won't be shown. Click here to find out more. |
jeromekelleher
approved these changes
Oct 8, 2024
python/CHANGELOG.rst
Outdated
|
|
||
| - Added ``genetic_relatedness_matrix`` method to compute | ||
| pairwise genetic relatedness between sample sets. | ||
| (:user:`jeromekelleher`, :user:`mmosmond`, :user:`petrelharp`, :pr:`2823`, :pr:`1623`) |
There was a problem hiding this comment.
I think this was just pr 2823, and mmosmond didn't really contribute
nspope
reviewed
Oct 9, 2024
python/CHANGELOG.rst
Outdated
|
|
||
| - Added ``pair_coalescence_counts`` method to calculate coalescence events per node or time | ||
| interval, and ``pair_coalescence_quantiles`` method to estimate quantiles of pair | ||
| coalescence times using empirical CDF inversion. |
There was a problem hiding this comment.
also:
and pair_coalescence_rates method to estimate instantaneous rates of pair coalescence within time intervals from the empirical CDF (:pr:2985)
|
LGTM aside from one missing PR -- thanks @benjeffery |
benjeffery
force-pushed
the
py-changelog
branch
2 times, most recently
from
7ac1037
to
25947a7
Compare
|
Codecov losing the plot and claiming I've reduced coverage by 3% by editing the changelog. Very tempted to move off it! EDIT Huh, it changed it's mind. |
benjeffery
force-pushed
the
py-changelog
branch
from
25947a7
to
9678165
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nspope @petrelharp
I've reviewed the diff of tskit and found that some new documented methods were missing changelogs. Have I got the details right here? Thanks!