Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw svg title #3015

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Draw svg title #3015

merged 1 commit into from
Oct 9, 2024

Conversation

hyanwong
Copy link
Member

@hyanwong hyanwong commented Oct 8, 2024

I've always wanted to be able to add a title to our SVG plots. Now that we are outputting them e.g. from sc2ts, I think this is vital to keep track of what we are plotting:

Screenshot 2024-10-08 at 23 04 10

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.84%. Comparing base (b527d0d) to head (8e6380f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3015    +/-   ##
========================================
  Coverage   89.84%   89.84%            
========================================
  Files          29       29            
  Lines       32093    32097     +4     
  Branches     6230     5756   -474     
========================================
+ Hits        28833    28837     +4     
  Misses       1859     1859            
  Partials     1401     1401            
Flag Coverage Δ
c-tests 86.69% <ø> (ø)
lwt-tests 80.78% <ø> (ø)
python-c-tests 89.05% <ø> (ø)
python-tests 99.00% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/tskit/drawing.py 99.23% <100.00%> (+<0.01%) ⬆️
python/tskit/trees.py 98.80% <ø> (ø)

Copy link
Member

@benjeffery benjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you need to drop intervals.py from the PR?

python/tskit/intervals.py Outdated Show resolved Hide resolved
@benjeffery
Copy link
Member

@Mergifyio rebase

Copy link
Contributor

mergify bot commented Oct 9, 2024

rebase

☑️ Nothing to do

  • any of:
    • #commits > 1 [📌 rebase requirement]
    • #commits-behind > 0 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • -conflict [📌 rebase requirement]
  • queue-position = -1 [📌 rebase requirement]

@benjeffery benjeffery merged commit dca04b3 into tskit-dev:main Oct 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants