Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODE: num_causal error #99

Merged
merged 1 commit into from
Sep 27, 2023
Merged

CODE: num_causal error #99

merged 1 commit into from
Sep 27, 2023

Conversation

daikitag
Copy link
Collaborator

Detect num_causal error in sim_trait function

Detect num_causal error in sim_trait function
@daikitag
Copy link
Collaborator Author

This is resolving #94

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #99 (b0b0f80) into main (8bbf1be) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #99   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          300       302    +2     
  Branches        31        31           
=========================================
+ Hits           300       302    +2     
Files Coverage Δ
tstrait/simulate_effect_size.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@GertjanBisschop
Copy link
Member

LGTM. Shall we do the same for the random_seed variable?

@daikitag
Copy link
Collaborator Author

For the random_seed variable, np.random.default_rng function https://numpy.org/doc/stable/reference/random/generator.html can have more inputs than integers, and I received a suggestion from Jerome saying that we shouldn't be trying to generate errors for that part.

@daikitag
Copy link
Collaborator Author

Thank you for your prompt feedback @GertjanBisschop

@GertjanBisschop
Copy link
Member

cool!

@mergify mergify bot merged commit 5371a97 into tskit-dev:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants