Skip to content

fix: github-pr-preview reporter use user selected filter_mode #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

tsuyoshicho
Copy link
Owner

Pull Request detail

Related issues or PRs/関連issueやPR

related snow-actions/sandbox#4

Fix or Add/Remove in this PR/このプルリクエストでやったこと

  • github-pr-review 指定時に filter_mode が反映されていないこと
  • 終了コードのハンドリングにも一部問題があること
  • fail_on_error もあつかっていないこと

Do not fix or add/remove this PR/このプルリクエストでやらなかったこと

  • なし

Pros and Cons/メリットとデメリット

  • ただしく filter_mode が作用し、さらに終了コード的な問題がない

Test/動作確認

tsuyoshicho/action-test-repo#45

@tsuyoshicho tsuyoshicho self-assigned this Aug 5, 2024
@tsuyoshicho tsuyoshicho added the bump:patch Bump up patch version label Aug 5, 2024
@tsuyoshicho tsuyoshicho merged commit 3d4a021 into master Aug 5, 2024
7 checks passed
@tsuyoshicho tsuyoshicho deleted the fix/previewhandling branch August 5, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump:patch Bump up patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant