Pluralize summary counts by number - #58
Merged
Merged
Conversation
The end-of-run summary hardcoded "package" for the changed count and "packages" for the unchanged count, so it read "1 packages" or "2 package" depending on the numbers. Add a small `_plural` helper and use it for both counts, so a count of 1 reads "package" and any other count reads "packages". Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K6m3rhqg4ssCTaan8K1BDi
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
==========================================
+ Coverage 98.32% 98.34% +0.01%
==========================================
Files 4 4
Lines 179 181 +2
Branches 35 35
==========================================
+ Hits 176 178 +2
Misses 2 2
Partials 1 1 ☔ View full report in Codecov by Harness. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts just the pluralization fix from #56, independent of that PR's dependency-sync feature.
The end-of-run summary hardcoded "package" for the changed count and "packages" for the unchanged count, so it read "1 packages" or "2 package" depending on the numbers. This adds a small
_pluralhelper and uses it for both counts: a count of 1 reads "package", any other count reads "packages".Tests updated to expect the pluralized output; verified the singular case (
1 package) manually.🤖 Generated with Claude Code