Open
Conversation
Contributor
Author
|
A known issue, "build datascript" trips and dies if custom dbc doesn't exist in dbc_source folder but I currently have no clue how to approach it yet. |
Bringing all changes tester made within Dusk fork, so change file format to cdbc, file generator, and so on.
Contributor
Author
Which is now resolved, thanks tester. |
Apparently SFileReadFile has a bit different definition than in StormLib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bringing custom DBC manager from Duskhaven's fork to main repository with one (for now) custom db. Thanks to @TesterWoWDev for huge help with this stuff - I would probably be still stuck with non-working version of this thing (ask tester about #pragma optimize("", off) 😄).
Went a bit out of scope - added a bunch of additional defines and namespaces that were meant for other PR but new code already relied on some of this stuff, I've decided to include all to not refactor again (it will [probably] happen regardless at some point but w/e for now).
During limited tests on local Dusk I didn't really find any issues, but I'm sure it requires more tests/