fix: harden output and release stability - #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and value
Archify's output paths were not consistently protected against input aliases, symbolic links, hard links, case/Unicode aliases, or last-moment target changes. Release-facing version labels, package contents, documentation, and tag behavior also needed one deterministic identity contract.
This PR makes output commits fail closed before user inputs or paired outputs can be replaced, and makes the exact zero-dependency archive and development release identity verifiable before publication.
No originating issue exists for this internal stability slice.
Scope
v2.13.0-dev.0across package metadata, Skill metadata, docs, templates, and generated artifacts.Stability impact
meta.outputvalues that are absolute, escape the working directory, resolve through a symlink outside it, do not end in.html, or alias an input now fail closed.archify.zip.290510cand18e6f7f.Tests run
cd archify && npm testcd archify && npm run test:webmcd archify && npx -y node@18 --test --test-name-pattern="cli: deliver --open launches" test/cli.test.mjsscripts/build-zip.sh /tmp/archify-merge-gate.IG50Dn/fresh.zipunzip -tq /tmp/archify-merge-gate.IG50Dn/fresh.zipdiff -qr /tmp/archify-merge-gate.IG50Dn/fresh/archify /tmp/archify-merge-gate.IG50Dn/checked/archifyarchify.zip.node scripts/package-smoke.mjs /tmp/archify-merge-gate.IG50Dn/fresh/archifygit diff --check main...HEADVisual evidence
Visual review skipped: this PR introduces no intended diagram geometry or visual behavior. Generated version labels, proof hashes, the checked-in Architecture Delta artifact, and proof media were rebuilt and exercised by the deterministic artifact and WebM gates above.
Generated artifacts
archify.zip.Checklist
npm testinarchify/.