This repository has been archived by the owner on Jan 20, 2020. It is now read-only.
Fix usage on recent versions of Firefox Mobile #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox Mobile has included support for the unprefixed version of the web notifications API since version 22. Unfortunately, it also seems to have kept navigator.mozNotification around, though it no longer seems to work. Move conditionals around in permissionLevel() so the unprefixed check takes precedence over the moz-prefixed check. Fixes GH ttsvetko#12.
ttsvetko
added a commit
that referenced
this pull request
Aug 7, 2014
Fix usage on recent versions of Firefox Mobile
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox Mobile has included support for the unprefixed version of the web
notifications API since version 22. Unfortunately, it also seems to have kept
navigator.mozNotificationaround, though it no longer seems to work. Moveconditionals around in
permissionLevel()so the unprefixed check takesprecedence over the
moz-prefixed check.Fixes GH #12.