Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 reimplement padding width calculation to fix border placement for languages with varying unicode character widths #367

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

ttytm
Copy link
Owner

@ttytm ttytm commented Oct 3, 2024

Resolves border bugs mentioned in #357

Screenshot_20241003_182137

The enhancement regarding the translations the issue is mentioning will be tracked separately.

…anguages with varying unicode character widths
Copy link

github-actions bot commented Oct 3, 2024

Filename                              Stmts    Miss  Cover    Missing
----------------------------------  -------  ------  -------  ------------------------------------------------------------
src/main.rs                              13      13  0.00%    26-43
src/modules/api.rs                       24      13  45.83%   26-29, 38, 49-88
src/modules/args.rs                       4       4  0.00%    91-95
src/modules/config.rs                    31      25  19.35%   52-97
src/modules/forecast.rs                  20       6  70.00%   7-8, 24-25, 27-28
src/modules/localization.rs             105      41  60.95%   162-203, 230-265
src/modules/location.rs                  53      28  47.17%   25-29, 59-63, 75, 89, 95-104, 109, 118-126, 131-132, 142-143
src/modules/params.rs                    52      52  0.00%    23-133
src/modules/units.rs                     13       0  100.00%
src/modules/weather.rs                   28      28  0.00%    83-154
src/modules/display/border.rs            47      47  0.00%    17-106
src/modules/display/current.rs           59      59  0.00%    37-222
src/modules/display/day.rs               69      69  0.00%    30-162
src/modules/display/graph.rs            169     164  2.96%    65-368
src/modules/display/gui_config.rs        15      12  20.00%   46-61
src/modules/display/historical.rs        71      71  0.00%    36-198
src/modules/display/hourly.rs           165     165  0.00%    40-396
src/modules/display/product.rs           21      21  0.00%    24-64
src/modules/display/utils.rs             38      38  0.00%    7-76
src/modules/display/weathercode.rs       31      31  0.00%    11-41
src/modules/display/week.rs              44      44  0.00%    31-123
src/modules/display/wind.rs              21      21  0.00%    17-42
TOTAL                                  1093     952  12.90%

Copy link

github-actions bot commented Oct 3, 2024

Test Results

9 tests  ±0   9 ✅ ±0   1s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 97dbc62. ± Comparison against base commit 2515863.

@ttytm ttytm merged commit a964606 into main Oct 3, 2024
30 checks passed
@ttytm ttytm deleted the fix/i18n-unicode-width-calculation branch October 3, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant