Quickly finish refreshing. #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If stop the freshing too quick, the method getOutRatio() will reset the boolean mIsRefreshing as true again. Then the refreshing would never stop. This can solve the problem.
|
Tested works great |
|
@xuncl @wscheffer CircleRefreshLayout.finishRefreshing() the header view not back |
|
@xuncl @wscheffer I believe you should change: if (!mIsRefreshing) {
applyDone();
}
if (isQuickStop){
mIsRefreshing = false;
isQuickStop = false;
}to if (isQuickStop){
mIsRefreshing = false;
isQuickStop = false;
}
if (!mIsRefreshing) {
applyDone();
} |
|
int CircleRefreshLayout.java private static final long BACK_TOP_DUR = 380; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user stops the freshing by
CircleRefreshLayout.finishRefreshing()immediately after the refresh starts, the methodAnimationView.startOutCir()will run after that and will reset the booleanAnimationView.mIsRefreshingas true again. Then the refreshing drawing will never stop.In this pr, the problem can be solved and make no damage to the animation effect.