Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove segment extraction from cmake #79

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

fpedd
Copy link
Collaborator

@fpedd fpedd commented Sep 17, 2021

This removes clutter in the binary directory when building with vector extension support.

@wysiwyng
Copy link
Contributor

A fix like this was already merged into ETISS a while ago: https://github.com/tum-ei-eda/etiss/blob/master/examples/SW/riscv/cmake/PulpinoTarget.cmake
Your source branch is far behind the current master, please check that first.

@fpedd
Copy link
Collaborator Author

fpedd commented Sep 17, 2021

The ml_on_mcu however still uses the v-ext-support branch until I get the vector stuff working on the master branch (which I don't know how long it will take. I would really like to first test the vector instruction from my PR #76 before merging them).

PS: the windows build only fails because the compiler runs out of memory: D:\a\etiss\etiss\ArchImpl\RISCV\RISCVArch.cpp(44454,1): fatal error C1060: compiler is out of heap space [D:\a\etiss\build\ArchImpl\RISCV\RISCV.vcxproj] (line 161 in the buildlog)

@rafzi
Copy link
Member

rafzi commented Sep 17, 2021

Since you are actively working on this feature, feel free to directly push to this branch if you need further backports.

@rafzi rafzi merged commit c2d04fd into tum-ei-eda:v-ext-support Sep 17, 2021
@fpedd
Copy link
Collaborator Author

fpedd commented Sep 17, 2021

@rafzi thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants