Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ComplexType support #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ComplexType support #18

wants to merge 2 commits into from

Conversation

i39
Copy link

@i39 i39 commented Jan 21, 2018

Hi and thanks for this great library.
This is my attempt to make ComplexType support in it.

@tuomur
Copy link
Owner

tuomur commented Feb 5, 2018

Thanks for taking a shot at this, PR looks really good.

But I wish it were that easy. If I remember correctly, the code in complextype.py does not handle nested ComplexTypes properly and the dict-like access is not very elegant compared to the rest of the package. I'm not sure it handles correctly in insert/update situations. It was left kinda... unfinished.

@i39
Copy link
Author

i39 commented Feb 6, 2018

Yes. You right. Thanks for reply. I'm working with it. And, if i'll find elegant solution i'll make another pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@i39 @tuomur