Remove Sled crypto store, use SQLite by default #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm honestly more inclined to replace the rust-sdk with something else. These zero-notice and breaking changes are becoming more hassle than it's worth. A migration path needs to be present for this SDK to drop sled, and the SDK will need to automatically do it in order to avoid a breaking change itself. |
on account of it being removed from the crypto-sdk
I've opened an issue to track this: element-hq#26 |
3 tasks
|
It looks like the rust-sdk bindings have stablized a bit since this was opened, which is great. I'm tempted to land this in a v1.0.0 of the bot-sdk, as it's a breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on account of it being removed from the crypto-sdk
Signed-off-by: Andrew Ferrazzutti [email protected]
Checklist