Make sure the offline storage version is consistent with migrations #9516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't see that e1afa84 also added a check but this fixes few more things |
charlag
force-pushed
the
offline-version-consistent
branch
2 times, most recently
from
e4c1d56 to
07502c6
Compare
hrb-hub
approved these changes
Aug 20, 2025
There was a missing check that migrations bring the version to the latest one. In addition, we were checking the version against non-populated metadata which worked accidentally on the first run because `undefined < 1 === false`.
hrb-hub
force-pushed
the
offline-version-consistent
branch
from
07502c6 to
1eef496
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a missing check that migrations bring the version to the latest one.
In addition, we were checking the version against non-populated metadata which worked accidentally on the first run because
undefined < 1 === true.