9534 snakbar hovered #9535
9534 snakbar hovered #9535
Conversation
BijinDev
force-pushed
the
9534-snakbar-hovered
branch
2 times, most recently
from
3886f16 to
1795628
Compare
src/common/gui/base/SnackBar.ts
Outdated
| @@ -164,6 +181,11 @@ function showNextNotification() { | |||
| let closed = false | |||
|
|
|||
| const closeAndOpenNext = (timedOut: boolean) => { | |||
| if (timedOut && hovered) { | |||
| debounce(1000, closeAndOpenNext)(true) | |||
There was a problem hiding this comment.
I didn't think of using a throw-away debounce() as a way to do setTimeout() 😅 not sure how I feel about it (actually I was now that it is also used this way in this file, weird).
Either way, if you schedule closeAndOpenNext() and then user manually closes it and then the timeout fires it might get into a weird state. closeFunction() might try to close the original snackbar, but the queue shift will remove another one from it.
Maybe I'm wrong also but this is from a quick glance.
There was a problem hiding this comment.
I didn't think of using a throw-away
debounce()as a way to dosetTimeout()😅 not sure how I feel about it (actually I was now that it is also used this way in this file, weird).
We did actually use setTimeout at first but then switched it to a debounce after we saw the one you mentioned 😅
Either way, if you schedule
closeAndOpenNext()and then user manually closes it and then the timeout fires it might get into a weird state.closeFunction()might try to close the original snackbar, but the queue shift will remove another one from it.
Good point! we'll fix it :)
hrb-hub
force-pushed
the
dev-mail
branch
2 times, most recently
from
3f612e3 to
baadc75
Compare
close #9534 Co-authored-by: hrb-hub <[email protected]>
Co-authored-by: bir <[email protected]>
hrb-hub
force-pushed
the
9534-snakbar-hovered
branch
from
1795628 to
7c37443
Compare
No description provided.