Add autosave #9578
Draft
Add autosave #9578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
paw-hub
force-pushed
the
4419-drafts
branch
22 times, most recently
from
a65b2cb to
515f5bb
Compare
This fixes a couple of problems with the throttle function. First off, it wasn't actually being exported, so InboxRuleHandler was importing it directly from its file. It's now correctly exported, and it seems this was the *only* use of throttle. Second off, lastArgs wasn't being saved, thus throttle wasn't actually debouncing but just creating a new timeout for every invocation. For example, if you called it 20 times with an interval of 5 seconds, it'd just call it 20 times after a 5 second delay. It now works like debounce() except that calling it does not restart the timer. Hopefully this doesn't cause any spacebar heating (see xkcd 1172) and InboxRuleHandler didn't actually depend on this behavior to work.
Fixes an oversight that can cause unintended data loss. This oversight is caused by the fact that autosaving happens regardless of if the draft was modified on another client. Without this change, an autosave could (ironically) cause data loss if the user has multiple clients and works on the draft on one client then continues on another client. Because closing a draft automatically saves the draft, it might save over the newer revision, causing data loss. For #4419 where the client will start periodically autosaving drafts, the client will attempt to upload autosaved drafts on startup without any input from the user. We only want an autosave to occur if this is safe to do. In the case that the user truly wants to save the draft, they can still press CTRL-S (Command-S on macOS / iPadOS, etc.) to manually save the draft while the draft editor is open.
paw-hub
force-pushed
the
4419-drafts
branch
5 times, most recently
from
054cad9 to
b6910bc
Compare
Closes #4419
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4419