Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ts plots #48

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Ts plots #48

merged 2 commits into from
Jan 26, 2024

Conversation

tvdboom
Copy link
Owner

@tvdboom tvdboom commented Jan 26, 2024

Related Issue or bug

Info about Issue or bug.

Fixes: #[issue number that will be closed through this PR]

Type of change

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Code style update (formatting, local variables).
  • Breaking change (fix or feature that would cause existing functionality to stop working).
  • This change requires a documentation update.

Describe the changes you've made

A clear and concise description of what you have done to successfully
close your assigned issue.

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so it can be reproduced.

Is there any unusual behaviour in your code?

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original Updated
original screenshot updated screenshot

@tvdboom tvdboom merged commit 7662554 into development Jan 26, 2024
@tvdboom tvdboom deleted the ts_plots branch January 26, 2024 08:00
Copy link

Qodana Community for Python

895 new problems were found

Inspection name Severity Problems
Unbound local variables 🔶 Warning 58
Depencencies in pyproject.toml 🔶 Warning 26
Incorrect type 🔶 Warning 22
Incorrect call arguments 🔶 Warning 18
Fixture is not requested by test functions 🔶 Warning 3
Attempt to call a non-callable object 🔶 Warning 1
The default argument is mutable 🔶 Warning 1
Overloads in regular Python files 🔶 Warning 1
Accessing a protected member of a class or a module ◽️ Notice 286
PEP 8 naming convention violation ◽️ Notice 271
PEP 8 coding style violation ◽️ Notice 95
An instance attribute is defined outside init`` ◽️ Notice 53
Shadowing names from outer scopes ◽️ Notice 39
Unused local symbols ◽️ Notice 17
Shadowing built-in names ◽️ Notice 2
Unclear exception clauses ◽️ Notice 1
Method is not declared static ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants