unmountHTMLWhenHide not working #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 waiting |
1 similar comment
|
+1 waiting |
|
+1 |
|
+1 waiting |
|
+1 |
1 similar comment
|
+1 |
| @@ -323,7 +323,7 @@ class Tippy { | |||
| if ( | |||
| isVisible(popper) || | |||
| !appendTo.contains(popper) || | |||
| getComputedStyle(tooltip).opacity === '1' | |||
| getComputedStyle(tooltip).opacity !== '1' | |||
There was a problem hiding this comment.
I have had a quick test, your fix seems to make the issue more than fix it, the tooltip in my usual use-case got stuck and never unmount out of DOM.
The original logic seems correct so, again, please help giving more clue / code snippet. Would very appreciate it.
|
Thanks @olya777 for your contribution, But could you ever reproduce the issue and please post some code snippet here so we could find what is the root cause and make sure our solution could solve it completely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see https://github.com/tvkhoa/react-tippy/issues/40