Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set and remove element aria-describedby base on popper #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Oct 2, 2018

  1. Set and remove element aria-describedby base on popper

    To fix aria attribute do not have valid value, issue: https://github.com/tvkhoa/react-tippy/issues/89
    
    As describedby need to point to a valid id, that means id that exists, while current implementation set it from beginning and keep it there even when the popper is hidden - removed from DOM.
    
    This update will help solve issue as we only set it when show and remove when hide the popper
    tuanthieu2993 committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    e4988eb View commit details
    Browse the repository at this point in the history