Update partial icons from the latest upstream version #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
force-pushed
the
xmr/icons
branch
3 times, most recently
from
cb5e31d to
faa35fc
Compare
patrickhlauke
requested changes
Mar 24, 2024
patrickhlauke
previously approved these changes
Mar 24, 2024
| @@ -1,4 +1,4 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg"{{ with .width }} width="{{ . }}"{{ end }}{{ with .height }} height="{{ . }}"{{ end }}{{ with .class }} class="{{ . }}"{{ end }} viewBox="0 0 16 16" role="img" fill="currentColor"> | |||
There was a problem hiding this comment.
it's fine not to have the role="img" on these, as without a matching <title> or aria-label="..." in the <svg> it's pointless anyway (and we do provide accessible names separately when these are used)
|
@patrickhlauke thanks! Can I or can you move your changes to a separate PR? That way it should be cleaner what we should do in the other repos since this PR is for the icons only :) |
|
@XhmikosR sure, let me split this into a separate PR and then clean this one up |
|
Done #442 |
Also: * switch Twitter to the X icon * switch to using `default` for missing values and stop passing the default ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-438--bootstrapblog.netlify.app/
@patrickhlauke could you please take a look? Do we still need
role="img?PS. You can check the code diff not the rich diff.