Improve error messages during check. #119
Conversation
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| case CBOR.deserialiseFromBytesWithSize CBOR.decodeTerm (BSL.fromStrict bytes) of | ||
| Left err -> failUnpack $ TextError $ "CBOR term deserialisation failed: " <> T.pack (show err) | ||
| Right (_rest, bytesRead, term) -> do | ||
| put (start + fromIntegral bytesRead) |
There was a problem hiding this comment.
What's the impact of dropping this line? It doesn't seem related to the error message change
There was a problem hiding this comment.
Good question I think I'll close this PR. And prepare another one
I wanted to write that this line is noop and that's true if everything is correct, however in case if not entire cbor structure is consumed there is a difference, and I think we should just fail here in that case
|
Converting to draft because the question @nc6 asked opens a deeper issue that should be resolved |
Slightly improves error messages in case if check fails. It’s still far from the optimal ones but at least mentions the offset where an error happens