Introduce gov/committee/v0 namespace #133
Conversation
qnikst
added this to the
Milestone 2 : Developpement of Haskell serialization code milestone
There was a problem hiding this comment.
Pull request overview
This PR introduces a new gov/committee/v0 namespace for handling governance committee data and refactors common CDDL definitions to improve code reusability.
- Creates new namespace module for governance committee specifications
- Moves shared credential and hash-related definitions from
Snapshots.hstoCommon.hsfor reuse across multiple namespaces - Renames
scripthashtoscript_hashfor consistency with naming conventions
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scls-cddl/cddl-src/Cardano/SCLS/Namespace/GovCommitee.hs | New file defining the governance committee namespace with record entry and committee structure specifications |
| scls-cddl/cddl-src/Cardano/SCLS/Common.hs | Adds shared CDDL definitions for credentials, key hashes, and script hashes moved from Snapshots.hs |
| scls-cddl/cddl-src/Cardano/SCLS/Namespace/Snapshots.hs | Removes definitions that have been relocated to Common.hs for better code organization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
qnikst
force-pushed
the
95-define-cddl-for-the-govcommittee-namespace-real
branch
from
b2dc50f to
b1d4da1
Compare
qnikst
force-pushed
the
95-define-cddl-for-the-govcommittee-namespace-real
branch
2 times, most recently
from
9f15303 to
445f692
Compare
nc6
left a comment
nc6
left a comment
There was a problem hiding this comment.
Generally looks OK, but there's some weird stuff going on with the 'GovProposal' file.
| =:= arr [0, a credential] | ||
| / arr [1, a (anchor / VNil)] | ||
|
|
||
| epoch_no :: Rule |
| {-# OPTIONS_GHC -Wno-unrecognised-pragmas #-} | ||
|
|
||
| {-# HLINT ignore "Use camelCase" #-} | ||
| module Cardano.SCLS.Namespace.GovCommittee where |
There was a problem hiding this comment.
Also this module doesn't appear used at all?
There was a problem hiding this comment.
Yeah, I didn't indent to send it in this PR. Removed it from the PR
qnikst
force-pushed
the
95-define-cddl-for-the-govcommittee-namespace-real
branch
from
445f692 to
1ae2071
Compare
qnikst
force-pushed
the
95-define-cddl-for-the-govcommittee-namespace-real
branch
from
1ae2071 to
3e889e4
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PR introduces and new namespace from the list