Make nixpkgs GHC 9.6.x work #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avdv
force-pushed
the
nixpkgs-ghc-9.6
branch
6 times, most recently
from
0e341c6 to
9370fdd
Compare
avdv
force-pushed
the
nixpkgs-ghc-9.6
branch
6 times, most recently
from
9a5f186 to
2e4dd52
Compare
avdv
force-pushed
the
nixpkgs-ghc-9.6
branch
4 times, most recently
from
b4c41fd to
d51957b
Compare
Some newer GHC versions have the `package.conf.d` below a `lib` directory.
... on Windows. The pkg conf file for rts has entries for `haddock-interface` and `haddock-html` but neither of those actually exist.
In previous GHC versions from nixpkgs, the `otool` setting was referencing a tool in the nix store, but for GHC 9.6.2 it is just set to "otool" which means it must be in `$PATH`. The same applies to the `install_name_tool`. See NixOS/nixpkgs#267250 and https://gitlab.haskell.org/ghc/ghc/-/issues/24211 We work around by using the location of the `ar` command and assume the other tools (from the bintools package) are also available at the same place.
avdv
force-pushed
the
nixpkgs-ghc-9.6
branch
4 times, most recently
from
6a27d24 to
019cb74
Compare
Trying to build this results in a bus error with ghc-iserv.
aherrmann
approved these changes
Dec 11, 2023
Comment on lines
+127
to
+134
| if hs.toolchain.is_darwin: | ||
| # assume `otool` and `install_name_tool` are available at the same location as `ar` | ||
| ar_bindir = paths.dirname(cc.tools.ar) | ||
|
|
||
| compile_flags += [ | ||
| "-pgmotool=" + paths.join(ar_bindir, "otool"), | ||
| "-pgminstall_name_tool=" + paths.join(ar_bindir, "install_name_tool"), | ||
| ] |
There was a problem hiding this comment.
I suspect this may fail for users that try to use a hermetic bindist cc toolchain like grail's llvm toolchain. I'm fine with this for now as it is an improvement over the status quo. But, from what I understand so far, this may not cover all use-cases, yet.
There was a problem hiding this comment.
Yes, we probably will need a better solution to this in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1920 and fixes #2031
Note that I had to skip the profiling test
//tests/haskell_module/dep-narrowing-th:Teston macos for GHC 9.6 as it crashes callingghc-iserv, see #2073.