Cleanup: remove deprecated options and targets #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avdv
force-pushed
the
cleanup-deprecated
branch
12 times, most recently
from
3cbfaf3 to
22bfb82
Compare
This option was deprecated since rules_haskell 0.14, so it is time to get rid of it.
These were introduced in rules_haskell 0.7 and have been deprecated since.
The core rules_haskell module only depends on rules_nixpkgs_* as dev dependencies, so do not reference these from the haskell package.
There is no need to build and run buildifier for each module and for every GHC version in order to keep the code base in shape. Tag the buildifier tests with `manual` and only run the buildifier for the top-level repository (which formats / lints all files of the git repo).
Use `//buildifier:buildifier_test` to check for proper formatting.
avdv
force-pushed
the
cleanup-deprecated
branch
from
22bfb82 to
87f4fe9
Compare
|
ping @aherrmann |
aherrmann
approved these changes
Nov 27, 2023
.github/workflows/workflow.yaml
Outdated
Comment on lines
99
to
132
| bazel test //... | ||
| bazel build //... |
There was a problem hiding this comment.
I guess this is done because rules_haskell_nix does not contain any tests (apart from the manual buildifier test)?
We need not to forget to switch this back if we every add tests again.
I wonder if it may be safer to add a dummy test and keep this as bazel test //....
There was a problem hiding this comment.
Good call. I added a small test and removed the test -> build commit.
```
WARNING: <root>/MODULE.bazel:216:24: The module extension go_deps defined in @gazelle//:extensions.bzl reported incorrect imports of repositories via use_repo():
Imported, but reported as indirect dependencies by the extension:
com_github_golang_mock, com_github_golang_protobuf, org_golang_google_genproto, org_golang_google_grpc, org_golang_google_protobuf, org_golang_x_net, org_golang_x_tools
** You can use the following buildozer command(s) to fix these issues:
buildozer 'use_repo_remove @gazelle//:extensions.bzl go_deps
com_github_golang_mock com_github_golang_protobuf org_golang_google_genproto
org_golang_google_grpc org_golang_google_protobuf org_golang_x_net
org_golang_x_tools' //MODULE.bazel:all
```
avdv
force-pushed
the
cleanup-deprecated
branch
2 times, most recently
from
e0c2095 to
0cfb659
Compare
avdv
force-pushed
the
cleanup-deprecated
branch
from
0cfb659 to
49e009b
Compare
avdv
force-pushed
the
cleanup-deprecated
branch
from
49e009b to
2a250dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compiler_flagsoption (users will get an error message now telling them to useghcoptsinstead, to ease the migration -- this error handling should be removed after the next version was released)