Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use depset for reexports in HaskellLibraryInfo #2125

Merged
merged 2 commits into from
Mar 7, 2024
Merged

use depset for reexports in HaskellLibraryInfo #2125

merged 2 commits into from
Mar 7, 2024

Conversation

prednaz
Copy link
Member

@prednaz prednaz commented Feb 20, 2024 •
edited
Loading

@prednaz prednaz force-pushed the philipp/reexport_depset branch from 0938720 to d98672a Compare February 21, 2024 18:50
@prednaz prednaz marked this pull request as ready for review February 21, 2024 21:55
@prednaz prednaz requested a review from avdv as a code owner February 21, 2024 21:55
@prednaz prednaz requested a review from thufschmitt February 21, 2024 22:41
avdv
avdv approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

haskell/providers.bzl Outdated Show resolved Hide resolved
@prednaz prednaz added merge-queue merge on green CI and removed merge-queue merge on green CI labels Mar 7, 2024
@prednaz prednaz force-pushed the philipp/reexport_depset branch from 3691dc8 to b210ba1 Compare March 7, 2024 18:15
@prednaz prednaz added the merge-queue merge on green CI label Mar 7, 2024
@mergify mergify bot merged commit fabe6d8 into master Mar 7, 2024
110 checks passed
@mergify mergify bot deleted the philipp/reexport_depset branch March 7, 2024 20:21
@mergify mergify bot removed the merge-queue merge on green CI label Mar 7, 2024
@aherrmann aherrmann mentioned this pull request Mar 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avdv avdv avdv approved these changes

@thufschmitt thufschmitt Awaiting requested review from thufschmitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prednaz @avdv