Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and fix CI jobs for Darwin #2175

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Conversation

avdv
Copy link
Member

@avdv avdv commented Apr 26, 2024

  • Do not invent version number
  • Use macos-12 runner images

This fixes the failing CI jobs for Darwin because of the roll-out of switching macos-latest to macos-14 arm64.


Currently, the CI bindist job for GHC 9.8.1 for rules_haskell_test fails with:

Error in fail: rule @//tests/haddock:haddock generates 
["haddock/array-0.5.6.0-ded9", "haddock/base-4.19.0.0-e537", "haddock/deepseq-1.5.0.0-5710", "haddock/ghc-bignum-1.3-b85e", "haddock/ghc-boot-th-9.8.1-29c5", "haddock/ghc-prim-0.11.0-2de8", "haddock/index", "haddock/pretty-1.1.3.6-913b", "haddock/template-haskell-2.21.0.0-4479", "haddock/testsZShaddockZShaddock-lib-a", "haddock/testsZShaddockZShaddock-lib-b", "haddock/testsZShaddockZShaddock-lib-deep"] 

not

 ["haddock/array-0.5.6.0-256c", "haddock/base-4.19.0.0-d6d2", "haddock/deepseq-1.5.0.0-c140", "haddock/ghc-bignum-1.3-93be", "haddock/ghc-boot-th-9.8.1-5d14", "haddock/ghc-prim-0.11.0-5379", "haddock/index", "haddock/pretty-1.1.3.6-eec0", "haddock/template-haskell-2.21.0.0-be6e", "haddock/testsZShaddockZShaddock-lib-a", "haddock/testsZShaddockZShaddock-lib-b", "haddock/testsZShaddockZShaddock-lib-deep"]

This also happens for all the renovate PRs.

I'll update the expeted values, but @aherrmann / @ylecornec do you have an idea why the suffix (is this the package id?) of the haskell_haddock outputs changed?

The version number is optional, the upstream issue was resolved.
@avdv
Copy link
Member Author

avdv commented Apr 26, 2024

I'll update the expeted values, but @aherrmann / @ylecornec do you have an idea why the suffix (is this the package id?) of the haskell_haddock outputs changed?

Oh, it's because macos-latest is arm64 now... which should be added / switched to in #1747

github/roadmap#926

Actions workflows using the macos-latest label will incrementally transition from macOS 12 to macOS 14 beginning April 8th 2024 and will conclude before the end of June 2024.

The macos-latest runner image is changed to point to macos-14 arm64.
@avdv avdv force-pushed the cb/cleanup-optional-version branch from db79348 to b7033f3 Compare April 26, 2024 08:21
@avdv avdv requested a review from aherrmann April 26, 2024 09:05
@avdv avdv marked this pull request as ready for review April 26, 2024 10:47
@avdv avdv added the merge-queue merge on green CI label Apr 26, 2024
@avdv avdv changed the title Cleanup Cleanup and fix CI jobs for Darwin Apr 26, 2024
@mergify mergify bot merged commit c53277e into master Apr 26, 2024
113 checks passed
@mergify mergify bot deleted the cb/cleanup-optional-version branch April 26, 2024 14:29
@mergify mergify bot removed the merge-queue merge on green CI label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants