Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency protobuf to v27 - autoclosed #2213

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 26, 2024

This PR contains the following updates:

Package Type Update Change
protobuf bazel_dep major 21.7 -> 27.3

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from avdv as a code owner June 26, 2024 08:02
@renovate renovate bot added the merge-queue merge on green CI label Jun 26, 2024
@aherrmann
Copy link
Member

Fails with

       external/abseil-cpp~20230802.0.bcr.1/absl/base/policy_checks.h:79:2: error: #error "C++ versions less than C++14 are not supported."
          79 | #error "C++ versions less than C++14 are not supported."
             |  ^~~~~

We should be able to fix this with tweag/rules_nixpkgs#557. Maybe a good time for a new rules_nixpkgs release.

@avdv
Copy link
Member

avdv commented Jul 8, 2024

Maybe a good time for a new rules_nixpkgs release.

👍 Yes. We also need a fix for the libcxxabi issue for newer nixpkgs and a fix for the darwin_x86-64 issue for Bazel 7. FYI @benradf

Fails with

       external/abseil-cpp~20230802.0.bcr.1/absl/base/policy_checks.h:79:2: error: #error "C++ versions less than C++14 are not supported."
          79 | #error "C++ versions less than C++14 are not supported."
             |  ^~~~~

I was able to work around that by passing --host_cxxopt=-std=c++14, see here: 467e2e7 (#2196)

@renovate renovate bot force-pushed the renovate/protobuf-27.x branch from 548068d to 7b39069 Compare July 31, 2024 18:31
@renovate renovate bot changed the title chore(deps): update dependency protobuf to v27 chore(deps): update dependency protobuf to v27 - autoclosed Sep 10, 2024
@renovate renovate bot closed this Sep 10, 2024
@renovate renovate bot deleted the renovate/protobuf-27.x branch September 10, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-queue merge on green CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants