Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up after release #566

Merged
merged 8 commits into from
Jul 12, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .bcr/config.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
moduleRoots:
- "core"
- "nodejs"
38 changes: 19 additions & 19 deletions .bcr/nodejs/presubmit.yml
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
bcr_test_module:
module_path: "testing"
matrix:
platform: ["ubuntu2204"]
bazel:
- "6.x"
tasks:
run_tests:
name: "Run test module"
platform: ${{ platform }}
bazel: ${{ bazel }}
environment:
# The Nix installer updates ~/.profile to set PATH. However, the Bazel
# CI setup seems to disregard ~/.profile. So we set PATH manually here.
PATH: /var/lib/buildkite-agent/.nix-profile/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
shell_commands:
- curl -L https://nixos.org/nix/install | sh -s -- --no-daemon
test_targets:
- "//..."
matrix:
platform:
- debian10
- ubuntu2004
- macos
# XXX not fully supported yet
#- macos_arm64
bazel:
- 7.x
- 6.x
tasks:
# XXX use testing module once all dependencies are available from the BCR
verify_targets:
name: Verify build targets
platform: ${{ platform }}
bazel: ${{ bazel }}
build_targets:
- '@rules_nixpkgs_nodejs//:nodejs'
- '@rules_nixpkgs_nodejs//extensions:toolchain'
22 changes: 22 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
---
name: Bug report
about: Create a bug report to help us fix it.
labels: 'type: bug'

---

**Describe the bug**
A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior.

**Expected behavior**
A clear and concise description of what you expected to happen.

**Environment**
- OS name + version:
- Version of the code:

**Additional context**
Add any other context about the problem here.
18 changes: 18 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
---
name: Feature request
about: Suggest an idea for this project.
labels: 'type: feature request'

---

**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

**Describe the solution you'd like**
A clear and concise description of what you want to happen.

**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.

**Additional context**
Add any other context or screenshots about the feature request here.
7 changes: 6 additions & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,9 @@ jobs:
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
gh release create --draft --notes-file release_notes.txt v${{ inputs.version }} rules_nixpkgs-${{ inputs.version }}.tar.gz
gh release create \
--draft \
--notes-file release_notes.txt \
--title v${{ inputs.version }} \
v${{ inputs.version }} \
rules_nixpkgs-${{ inputs.version }}.tar.gz
12 changes: 10 additions & 2 deletions .github/workflows/release_prep.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,26 @@ TAG=$1
PREFIX="rules_nixpkgs-${TAG:1}"
ARCHIVE="rules_nixpkgs-${TAG:1}.tar.gz"
git archive --format=tar.gz --prefix="${PREFIX}/" -o $ARCHIVE HEAD
SHA=$(shasum -a 256 "$ARCHIVE" | awk '{print $TAG}')
SHA=$(shasum -a 256 "$ARCHIVE" | awk '{print $1}')

cat << EOF
## Using Bzlmod with Bazel 6
## Using Bzlmod with Bazel 6+
1. Enable with \`common --enable_bzlmod\` in \`.bazelrc\`.
2. Add to your \`MODULE.bazel\` file:
### For the core module
\`\`\`starlark
bazel_dep(name = "rules_nixpkgs_core", version = "${TAG:1}")
\`\`\`
### For the nodejs module
\`\`\`starlark
bazel_dep(name = "rules_nixpkgs_nodejs", version = "${TAG:1}")
\`\`\`
## Using WORKSPACE
Paste this snippet into your \`WORKSPACE.bazel\` file:
Expand Down
Loading