Skip to content

fix(server): enhance logo handling in UserWorkspaceService #14581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix(server): enhance logo handling in UserWorkspaceService #14581

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d955176
fix(server): enhance logo handling in `UserWorkspaceService`
zhyd1997 Sep 17, 2025
ef508b2
style(server): lint fix.
zhyd1997 Sep 17, 2025
793ff76
Merge branch 'main' into fix/workspace-switch-avatar-issue-14572-1758…
FelixMalfait Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion packages/twenty-server/src/engine/core-modules/user-workspace/user-workspace.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,11 +377,24 @@ export class UserWorkspaceService extends TypeOrmQueryService<UserWorkspace> {
}

castWorkspaceToAvailableWorkspace(workspace: Workspace) {
let signedLogo: string | undefined = workspace.logo ?? undefined;

if (isDefined(workspace.logo)) {
try {
signedLogo = this.fileService.signFileUrl({
url: workspace.logo as string,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant force cast

workspaceId: workspace.id,
});
} catch {
signedLogo = workspace.logo as string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be undefined, wrong force cast

}
}

return {
id: workspace.id,
displayName: workspace.displayName,
workspaceUrls: this.domainManagerService.getWorkspaceUrls(workspace),
logo: workspace.logo,
logo: signedLogo,
sso:
workspace.workspaceSSOIdentityProviders?.reduce(
(acc, identityProvider) =>
Expand Down