fix: updated dropdown's bg for better readability over bright bg #14700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix dropdown readability in dark theme over bright backgrounds
Problem
In dark theme, dropdowns wrapped by
OverlayContainer
had poor readability when displayed over bright/white backgrounds. The issue was caused bytheme.background.transparent.primary
having only 50% opacity, which didn't provide sufficient contrast against bright backgrounds even with the blur effect applied.Solution
Changed the background property in
OverlayContainer
fromtheme.background.transparent.primary
totheme.background.overlayPrimary
.Before
After
Testing
Technical Details
The
overlayPrimary
background provides better contrast across both themes:RGBA(gray100, 0.8)
- 80% opacity white overlay for better contrast over bright backgroundsRGBA(gray80, 0.8)
- 80% opacity dark overlay for consistent contrastFiles Changed
packages/twenty-front/src/modules/ui/layout/overlay/components/OverlayContainer.tsx
The change ensures that dropdown content remains clearly readable regardless of what's behind it, while maintaining the aesthetic blur effect. Test by:
Fixes #11916