-
Notifications
You must be signed in to change notification settings - Fork 4.2k
CRON trigger design improvements and i deleted the schedule part #14748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Welcome!
Hello there, congrats on your first PR! We're excited to have you contributing to this project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Summary
This PR implements design improvements to the CRON trigger UI by simplifying the display and removing the schedule description section.
The main changes include:
- Added a new
StyledExpressionLabel
component toInputLabel.tsx
for consistent styling of expression labels - Modified
CronExpressionHelper.tsx
to remove the schedule description section and improve the visual design - Updated container and section styling with better background colors, borders, and spacing
- Streamlined the UI to focus only on upcoming execution times rather than showing both schedule description and execution times
The changes align with the issue requirements to improve the CRON trigger design and create a cleaner, more focused user interface.
Confidence Score: 4/5
- This PR is safe to merge with minor syntax fixes needed
- Score reflects UI improvements that align with design requirements, but syntax issues need attention
- InputLabel.tsx needs syntax fixes for spacing and newline issues
Important Files Changed
File Analysis
Filename | Score | Overview |
---|---|---|
packages/twenty-front/src/modules/ui/input/components/InputLabel.tsx | 3/5 | Added StyledExpressionLabel component with minor syntax issues (double space, missing newline) |
packages/twenty-front/src/modules/workflow/workflow-trigger/components/CronExpressionHelper.tsx | 4/5 | Improved UI design by removing schedule section and updating styling, with minor whitespace issue |
Sequence Diagram
sequenceDiagram
participant User
participant CronTriggerUI as CRON Trigger UI
participant InputLabel as InputLabel Component
participant CronHelper as CronExpressionHelper
participant ThemeProvider
User->>CronTriggerUI: Views CRON trigger configuration
CronTriggerUI->>CronHelper: Renders CronExpressionHelper component
CronHelper->>InputLabel: Imports StyledExpressionLabel
InputLabel->>ThemeProvider: Applies theme styles (background, spacing)
CronHelper->>CronHelper: Removes schedule description section
CronHelper->>ThemeProvider: Applies new container and section styling
CronHelper->>User: Displays simplified UI with upcoming executions only
2 files reviewed, 3 comments
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:28130 This environment will automatically shut down when the PR is closed or after 5 hours. |
Hello! Could you please keep the schedule part as a hint like in the original issuer + Fix tests (linter). Also don't harcode value but use theme values. Thank you |
And also check if there isn't already components you can re-use or define/do something clean instead of creating local custom styles. Thanks |
fix #14723