After createOneDbConnection mutation, update cache manually instead of using refetchQuery #5684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| }, | ||
| }; | ||
|
|
||
| if (isDefined(cache.readQuery(getManyDatabaseConnectionsQuery))) { |
There was a problem hiding this comment.
Ensure cache.readQuery returns a defined result before updating the cache.
ijreilly
changed the title
ijreilly
changed the title
Weiko
pushed a commit
that referenced
this pull request
May 31, 2024
…f using refetchQuery (#5684) Closes #5057. RefetchQuery is unreliable - [it won't be executed if the component is unmounted](apollographql/apollo-client#5419), which is the case here because of the redirection that occurs after the mutation. We want to avoid using refetchQuery as much as possible, and write directly in the cache instead.
arnavsaxena17
pushed a commit
to arnavsaxena17/twenty
that referenced
this pull request
Oct 6, 2024
…f using refetchQuery (twentyhq#5684) Closes twentyhq#5057. RefetchQuery is unreliable - [it won't be executed if the component is unmounted](apollographql/apollo-client#5419), which is the case here because of the redirection that occurs after the mutation. We want to avoid using refetchQuery as much as possible, and write directly in the cache instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5057.
RefetchQuery is unreliable - it won't be executed if the component is unmounted, which is the case here because of the redirection that occurs after the mutation.
We want to avoid using refetchQuery as much as possible, and write directly in the cache instead.