Improve nozzle continuity equations #3

LouisFonteneauMarcel · 2024-08-22T08:43:37Z

Improve nozzle modelling to ensure continuity in the equations between subsonic and sonic state in convergent nozzles

- Defined new test on NozzleAero to fit thermodynamics equations defined in other codes - Defined another definition for nozzle aero to help clarify equations

…ow calculation at the outlet

…test_run_once_shaft (wasn't running before)

…et or due to the new way of calculating the nozzle's performance (need a reference nozzle)

GuyDSP

thank you for PR. mainly comments to respect from the begining the good practices

GuyDSP · 2024-08-22T14:43:31Z

pyturbo/systems/nozzle/run/run_nozzle_aero.py

could you avoid scrypt and use tests instead ?

Script has been removed

GuyDSP · 2024-08-22T14:44:40Z

pyturbo/systems/nozzle/nozzle_aero.py

+        self.add_outward("Ps1", 0.0, unit="pa", desc="static pressure at inlet")
+        self.add_outward("Ps2", 0.0, unit="pa", desc="static pressure at outlet")
+        self.add_outward("Ps_crit", 0.0, unit="pa", desc="critical static pressure at throat")
+        self.add_outward("Ts1", 0.0, unit="pa", desc="static pressure at inlet")
+        self.add_outward("Ts2", 0.0, unit="pa", desc="static pressure at outlet")
+        self.add_outward("M1", 0.0, unit="", desc="mach at inlet")
+        self.add_outward("M2", 0.0, unit="", desc="mach at outlet")
+        self.add_outward("mach", 0.0, unit="", desc="mach at outlet")
+        self.add_outward("rho_2", 1.2, unit="kg/m**3", desc="Fluid density at outlet")
+        self.add_outward("speed", 0.0, unit="m/s", desc="fluid flow speed at outlet")


do not add outwards unless they are necessary (mainly, used for postprocessing or for connections).
please also respect the conventional case

unnecessary outwards have been removed and conventional case has been applied

GuyDSP · 2024-08-22T14:45:10Z

pyturbo/systems/nozzle/nozzle_aero.py

+        self.add_inward("gamma", 1.4, unit="", desc="Heat capacity ratio")
+        self.add_inward("rho_1", 1.2, unit="kg/m**3", desc="Fluid density at inlet")


that should be calculated from fluid lfow inputs

GuyDSP · 2024-08-22T14:46:10Z

pyturbo/systems/nozzle/nozzle_aero.py

+        self.Ps_crit = ((2 / (self.gamma + 1)) ** (self.gamma / (self.gamma - 1))) * self.fl_out.Pt
+        self.Ps1 = self.fl_in.Pt - 0.5 * ((self.fl_in.W**2) / (self.rho_1 * (self.area_in**2)))
+        self.Ps2 = max(self.Ps_crit, self.pamb)


see gas thermo librairy each time it is possible

Code has been modified to use thermo library functions are used whe possible

GuyDSP · 2024-08-22T14:46:34Z

pyturbo/systems/nozzle/nozzle_aero.py

+        self.Ps1 = self.fl_in.Pt - 0.5 * ((self.fl_in.W**2) / (self.rho_1 * (self.area_in**2)))
+        self.Ps2 = max(self.Ps_crit, self.pamb)
+
+        self.rho_2 = self.rho_1 * ((self.Ps2 / self.Ps1) ** (-self.gamma))


isentropic expension ? use thermo library

The approach is different now, hence this expansion is no longer calculated and the thermo library has been use

GuyDSP · 2024-08-22T14:47:11Z

pyturbo/systems/nozzle/simple_nozzle.py

+        self.add_inward("S_inlet", value=3.14159)
+        self.add_inward("S_outlet", value=2.0)
+


respect conventional name when ever possible

Component has been removed as it was useless

…static pressure at the outlet, equality of flow inlet and outlet to calulate the flow's state at the outlet of a fixed geometry nozzle)

…, the mach number in a convergent nozzle should not exceed 1. However density may not be considered constant anymore as we study compressible flows (M>0.3)

… "simple_nozzle.py"

…also pythermo lib functions in compute

…converging diverging architecture or solo converging

…ring a new inward

…at throat intialization

… one to test a system swap in the turbo fan, more thermo library function were used

…part yet

…ozzle.

LouisFonteneauMarcel · 2024-08-27T14:24:37Z

The critical pressure calculation from static temperature and total pressure has been added as function in the "thermo" module of pyturbo:

def pcrit_f_pt(self, pt: float, ts: float) -> float:
        gamma = self.gamma(ts)
        pcrit = pt * (2 / (gamma + 1)) ** (gamma / (gamma - 1))
        return pcrit

GuyDSP

few minor comments, thank you Louis !

GuyDSP · 2024-08-30T14:51:01Z

pyturbo/systems/nozzle/nozzle_aero.py

+        self.add_inward("area_in", 0.0625 * np.pi, unit="m**2", desc="inlet aero section")
+        self.add_inward("area_exit", 0.0225 * np.pi, unit="m**2", desc="exit aero section")
+        self.add_inward("area", 0.0225 * np.pi, unit="m**2", desc="choked/exit area")


strange value. radius square ? specific ? should have more explicite data.

Indeed those values are already squared, the definition is modified in regards to this lack of clarity

GuyDSP · 2024-08-30T15:44:13Z

pyturbo/thermo/ideal_gas.py

+    def pcrit_f_pt(self, pt: float, ts: float) -> float:
+        gamma = self.gamma(ts)
+        pcrit = pt * (2 / (gamma + 1)) ** (gamma / (gamma - 1))
+        return pcrit
+


what is it ?

It was a recalculation of critical static pressure, it has been removed because it is useless, the static_p function calculates the same thing when Mach=1

- Removed recalculation of critical pressure as it can be defined with static_p with mach argument equal to 1

GuyDSP

Thank you Louis !

LouisFonteneauMarcel added 6 commits August 22, 2024 10:41

First elements to improve nozzle continuity equations:

e935669

- Defined new test on NozzleAero to fit thermodynamics equations defined in other codes - Defined another definition for nozzle aero to help clarify equations

Simple nozzle with Mach defined at inlet and outlet

c38fbe1

modified equations to calculate the variations in density for mass fl…

bdc401a

…ow calculation at the outlet

modified nozzle aero and test to capture datas of mach number

3c3e7e0

repair all tests except test_nozzle, different values calculated and …

5a241ee

…test_run_once_shaft (wasn't running before)

modified test_nozzle as I can't figure out if the value is an error y…

311d4ca

…et or due to the new way of calculating the nozzle's performance (need a reference nozzle)

GuyDSP suggested changes Aug 22, 2024

View reviewed changes

LouisFonteneauMarcel added 13 commits August 22, 2024 17:52

Modified unitary test to target one purpose for the nozzle (Free the …

cd23bfc

…static pressure at the outlet, equality of flow inlet and outlet to calulate the flow's state at the outlet of a fixed geometry nozzle)

Modified test as without if condtionning in the compute of the nozzle…

ddbcb20

…, the mach number in a convergent nozzle should not exceed 1. However density may not be considered constant anymore as we study compressible flows (M>0.3)

Modified case and outwards after review, removed unecessary component…

5d6baeb

… "simple_nozzle.py"

Modified residue and unkown for outlet mach number calculation, used …

b50f26a

…also pythermo lib functions in compute

added De Laval nozzle test befor building a converging diverging nozzle

6f919b8

Modified Nozzle architecture to make a general nozzle with potential …

94c41bc

…converging diverging architecture or solo converging

Use ideal_gas gamma function for heat capacity ratio instead of decla…

f116282

…ring a new inward

More tests for different inlet mach number to force the work on mach …

4182659

…at throat intialization

redefined the nozzle aero model with an advanced one and used the old…

118544e

… one to test a system swap in the turbo fan, more thermo library function were used

First tests working, not limited at mach=1 for maximum in converging …

9cf7167

…part yet

pre-commit and comments added

b9b9c30

Tests on converging nozzle working

fad4f29

Converging Nozzle model modified for better evaluation of a started n…

08b8a57

…ozzle.

LouisFonteneauMarcel requested a review from GuyDSP August 27, 2024 14:37

GuyDSP suggested changes Aug 30, 2024

View reviewed changes

- More explicit area parameters

020d3c8

- Removed recalculation of critical pressure as it can be defined with static_p with mach argument equal to 1

GuyDSP approved these changes Sep 2, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve nozzle continuity equations #3

Improve nozzle continuity equations #3

LouisFonteneauMarcel commented Aug 22, 2024

GuyDSP left a comment

GuyDSP Aug 22, 2024

LouisFonteneauMarcel Aug 23, 2024

GuyDSP Aug 22, 2024

LouisFonteneauMarcel Aug 23, 2024

GuyDSP Aug 22, 2024

GuyDSP Aug 22, 2024

LouisFonteneauMarcel Aug 23, 2024

GuyDSP Aug 22, 2024

LouisFonteneauMarcel Aug 23, 2024

GuyDSP Aug 22, 2024

LouisFonteneauMarcel Aug 23, 2024

LouisFonteneauMarcel commented Aug 27, 2024

GuyDSP left a comment

GuyDSP Aug 30, 2024

LouisFonteneauMarcel Sep 2, 2024

GuyDSP Aug 30, 2024

LouisFonteneauMarcel Sep 2, 2024

GuyDSP left a comment

		self.add_inward("gamma", 1.4, unit="", desc="Heat capacity ratio")
		self.add_inward("rho_1", 1.2, unit="kg/m**3", desc="Fluid density at inlet")

		self.add_inward("S_inlet", value=3.14159)
		self.add_inward("S_outlet", value=2.0)

Improve nozzle continuity equations #3

Are you sure you want to change the base?

Improve nozzle continuity equations #3

Conversation

LouisFonteneauMarcel commented Aug 22, 2024

GuyDSP left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LouisFonteneauMarcel commented Aug 27, 2024

GuyDSP left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GuyDSP left a comment

Choose a reason for hiding this comment