Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rocket twin #13

Merged
merged 39 commits into from
Jul 4, 2023
Merged

Rocket twin #13

merged 39 commits into from
Jul 4, 2023

Conversation

luca7084
Copy link
Contributor

Passage to new rocket model, with new architecture and more modular structure.

luca7084 and others added 30 commits June 7, 2023 11:01
@luca7084 @adriendelsalle
Reformatted the code according to python standards
b620b3b
@luca7084 @adriendelsalle
Reformating according to pep8 rules
12a9c83
@luca7084 @adriendelsalle
Proposed architecture for new code
8bc2459
@luca7084
black + isort check
a69c568
@luca7084
Added models of rocket nose components
da784f0
@luca7084
Attempt at modelling components by mesh
0b08f01
@luca7084
Numerical implementation of some components
5993d9c
@luca7084
Added test for parabolic nose, new code structure
1e75db0
@luca7084
Calculs on Cn, Cd and CPA, added some connexions
2796464
@luca7084
Updated aerodynamic forces and moments computation
b73917c
@luca7084
.py files, finished aerodynamic computations
5f1e1c4
@luca7084
Added pressure, density and gravity models
a401c97
@luca7084
Rocket with reservatory, constant mass
fd13625
@luca7084
Added variable mass
df9bca8
@luca7084
Added center of gravity computation
e03b18f
@luca7084
Added ground reservatory and pipe
1b1ec39
@luca7084
Added unit tests
578c4a5
@luca7084
Added class folders and mission drivers
0982540
@luca7084
Doubles in same folder, organised modules
52060f5
@luca7084
Removed python template folder (added by mistake)
5e24a03
@luca7084
Organized files, unique tank class, corrected name
0f7270e
@adriendelsalle
fix pytest error
0d7a046 
add configuration to init pytest in cwd
@adriendelsalle
add missing conda deps
f278ca3
@adriendelsalle
use a standard gitignore file
e07c35a
@luca7084
black + isort
ba09e08
@luca7084
Corrected pipe design, added sequences
4b271ba
@luca7084
Changed variable names
bf547e7
@luca7084
Modular ground class, pre-commit, typos
1270e47
@luca7084
pre-commit
d6fa789
@luca7084
Bug fixes
7c53090
@GuyDSP
Copy link

GuyDSP commented Jul 2, 2023

Thank you Luca.
Take a meaningfull name for the branch (here could be "cleaning repo")
Good job, with clear documentation !
Architecture looks good with one exception : the way you manage the pipe opening and closing. Changing parent value in a system is forbeten, it impact the overall solver strategy. You must find an other way (what an easy tassk).
RocketGeom is not necessary (and is not what we expect as a Geom module).You should merge it with Dynamics to compute weight and cg.

GuyDSP
GuyDSP requested changes Jul 2, 2023
View reviewed changes
rocket_twin/drivers/mission.py Outdated Show resolved Hide resolved
rocket_twin/drivers/mission.py Outdated Show resolved Hide resolved
rocket_twin/drivers/mission.py Outdated Show resolved Hide resolved
rocket_twin/drivers/fueling_rocket.py Outdated Show resolved Hide resolved
rocket_twin/drivers/fueling_rocket.py Outdated Show resolved Hide resolved
rocket_twin/tests/test_dynamics.py Outdated Show resolved Hide resolved
rocket_twin/tests/test_flying_rocket.py Outdated Show resolved Hide resolved
rocket_twin/tests/test_mission.py Outdated Show resolved Hide resolved
rocket_twin/tests/test_refuel_rocket.py Outdated Show resolved Hide resolved
rocket_twin/utils/run_sequences.py Outdated Show resolved Hide resolved
GuyDSP
GuyDSP requested changes Jul 3, 2023
View reviewed changes
rocket_twin/drivers/fueling_rocket.py Outdated Show resolved Hide resolved
rocket_twin/drivers/mission.py Outdated Show resolved Hide resolved
rocket_twin/drivers/vertical_flying_rocket.py Outdated Show resolved Hide resolved
rocket_twin/notebooks/test_sequences.ipynb Outdated Show resolved Hide resolved
rocket_twin/systems/__init__.py Outdated Show resolved Hide resolved
rocket_twin/systems/ground.py Outdated Show resolved Hide resolved
rocket_twin/systems/physics/dynamics.py Outdated Show resolved Hide resolved
rocket_twin/systems/rocket/rocket.py Outdated Show resolved Hide resolved
rocket_twin/systems/station/station.py Outdated Show resolved Hide resolved
rocket_twin/systems/tank/tank.py Outdated Show resolved Hide resolved
GuyDSP
GuyDSP approved these changes Jul 4, 2023
View reviewed changes
rocket_twin/systems/tank/tank.py Outdated Show resolved Hide resolved
@GuyDSP
Copy link

GuyDSP commented Jul 4, 2023

Thank you Luca.
Last small request than go for merging!

@luca7084 luca7084 merged commit 6ccbe43 into main Jul 4, 2023
2 checks passed
@adriendelsalle adriendelsalle deleted the rocket_twin branch July 5, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuyDSP GuyDSP GuyDSP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luca7084 @GuyDSP @adriendelsalle