All tests passed with vector coordinates #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuyDSP
requested changes
Dec 11, 2023
rocket_twin/tests/test_temp.py
Outdated
There was a problem hiding this comment.
Okay, we will make the pull request to the dev_master_x branch from now on.
Regarding the test_temp, we will remove it eventually, but for now it is usefull for us to check that the system remains consistent with physics.
There was a problem hiding this comment.
could you add a new test to check what you want to chck with the tmp file ?
There was a problem hiding this comment.
I deleted it for now, before adding a test that will look more like a test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure about the pre commit