Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(model, gateway): add support for VOICE_CHANNEL_EFFECT_SEND event #2187

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(model, gateway): add support for VOICE_CHANNEL_EFFECT_SEND event #2187

wants to merge 1 commit into from

Conversation

suneettipirneni
Copy link
Member

Adds support for the VOICE_CHANNEL_EFFECT_SEND event. This event is fired when a user sends a soundboard sound uses the shared canvas or uses an emoji reaction.

Ref:

Needs testing

@github-actions github-actions bot added c-cache Affects the cache crate c-gateway Affects the gateway crate c-model Affects the model crate t-feature Addition of a new feature labels Mar 28, 2023
vilgotf
vilgotf reviewed Mar 28, 2023
View reviewed changes
Copy link
Member

@vilgotf vilgotf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not obvious to me if will be documented (i.e. if it's useful for bots). Maybe the fact that the PRs opened by advaith1 is proof enough.

Anyway, as always this looks very good. Impressive that you wrote it so quickly.

twilight-gateway/src/event.rs
/// Webhook in a guild has been updated.
const WEBHOOKS_UPDATE = 1 << 44;
const WEBHOOKS_UPDATE = 1 << 45;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space

Suggested change

twilight-model/src/gateway/payload/incoming/voice_channel_effect_send.rs
}

#[derive(Clone, Debug, Deserialize, Eq, Hash, PartialEq, Serialize)]
pub enum VoiceChannelEffectAnimationType {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always has to place items, should this be under the voice module? Hard to say

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vilgotf vilgotf vilgotf left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
c-cache Affects the cache crate c-gateway Affects the gateway crate c-model Affects the model crate t-feature Addition of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suneettipirneni @vilgotf