fix(models): add "flags" field to MemberUpdate payload #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kelwing
changed the title
|
Looks like this field is also not documented by Discord (https://discord.com/developers/docs/topics/gateway-events#guild-member-update) |
|
No it is not, but it is most definitely sent, and is analogous to the one in the Member object. |
|
I think we should see if they want to add it to the documentation before we look into adding it here. |
|
I have opened a PR against the Discord docs to get this added: discord/discord-api-docs#6717 |
|
@Kelwing Discord have accepted my pr, do you have anything aginst rebasing this, then we can merge it. |
Erk-
approved these changes
May 15, 2024
HTGAzureX1212
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
flagsfield to the MemberUpdate gateway model. Discord sends this field, but it is not captured by Twilight, and is incredibly useful when working with servers that have onboarding enabled.