Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(model, http): Add support for message forwarding #2340

Merged
merged 4 commits into from
Jul 18, 2024
Merged

feat(model, http): Add support for message forwarding #2340

merged 4 commits into from
Jul 18, 2024

Conversation

suneettipirneni
Copy link
Member

@github-actions github-actions bot added c-cache Affects the cache crate c-http Affects the http crate c-model Affects the model crate c-standby Affects the standby crate t-feature Addition of a new feature labels May 10, 2024
@suneettipirneni suneettipirneni self-assigned this May 10, 2024
@suneettipirneni suneettipirneni requested a review from a team May 10, 2024 17:01
Erk-
Erk- requested changes May 14, 2024
View reviewed changes
Copy link
Member

@Erk- Erk- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small nits otherwise it looks good.

twilight-model/src/channel/message/reference_type.rs Outdated Show resolved Hide resolved
twilight-model/src/channel/message/snapshot.rs Show resolved Hide resolved
@suneettipirneni suneettipirneni requested a review from Erk- May 14, 2024 17:00
@suneettipirneni suneettipirneni enabled auto-merge (squash) July 13, 2024 02:02
HTGAzureX1212
HTGAzureX1212 reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@HTGAzureX1212 HTGAzureX1212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approved after conflicts are resolved.

@suneettipirneni suneettipirneni merged commit d767129 into main Jul 18, 2024
9 checks passed
@suneettipirneni suneettipirneni deleted the feat/message-forwarding branch July 18, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erk- Erk- Erk- approved these changes

@HTGAzureX1212 HTGAzureX1212 HTGAzureX1212 approved these changes

Assignees

@suneettipirneni suneettipirneni

Labels
c-cache Affects the cache crate c-http Affects the http crate c-model Affects the model crate c-standby Affects the standby crate t-feature Addition of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suneettipirneni @Erk- @HTGAzureX1212