Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Lerna #450

Merged
merged 13 commits into from
Jan 17, 2023
Merged

Remove Lerna #450

merged 13 commits into from
Jan 17, 2023

Conversation

dkundel
Copy link
Member

@dkundel dkundel commented Dec 30, 2022

Work Included:

  • Replace lerna for bootstrapping and task running in favor of npm workspaces
  • Upgrade TypeScript to 4.9.4
  • Upgrade Jest and ts-jest
  • Replace lerna in favor of changesets for versioning
  • Setup release pipeline through GitHub Actions similar to github.com/twilio-labs/plugin-webhook

Known Issues:

  • The requireFromProject.test.ts files are currently partially disabled because npm workspaces hoists the twilio dependency to the root node_modules folder instead of having multiple instances. This results in the test no longer working. Virual mocks might be an alternative but needs validation.`
  • skipLibCheck is currently enabled in the tsconfig.base.json because @types/inquirer and execa were throwing issues --> Moved to Turn off skipLibCheck in tsconfig #451
  • useUnknownInCatchVariables is currently disabled as it was a breaking change between TypeScript 3.x and 4.4 and requires code changes. --> Moved to Re-enable useUnknownInCatchVariables #452
  • Netlify build is currently failing.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@dkundel dkundel marked this pull request as ready for review December 30, 2022 18:38
@changeset-bot
Copy link

changeset-bot bot commented Dec 30, 2022

🦋 Changeset detected

Latest commit: 0660137

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
twilio-run Patch
@twilio-labs/plugin-serverless Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dkundel dkundel requested a review from mbeldartwilio January 3, 2023 20:12
Copy link
Contributor

@bnb bnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some notes, mostly about version choices. None of these are blocking, LGTM otherwise :)

.github/workflows/nodejs.yml Outdated Show resolved Hide resolved
.github/workflows/nodejs.yml Outdated Show resolved Hide resolved
.github/workflows/on-merge-main.yml Outdated Show resolved Hide resolved
.github/workflows/nodejs.yml Outdated Show resolved Hide resolved
.github/workflows/on-merge-main.yml Outdated Show resolved Hide resolved
.github/workflows/on-merge-main.yml Show resolved Hide resolved
package.json Show resolved Hide resolved
Copy link
Contributor

@gautam678 gautam678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But left minor comments.

.github/workflows/nodejs.yml Outdated Show resolved Hide resolved
docs/CONTRIBUTING.md Show resolved Hide resolved
@dkundel dkundel merged commit 2c8133c into main Jan 17, 2023
@github-actions github-actions bot mentioned this pull request Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants