-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Lerna #450
Remove Lerna #450
Conversation
🦋 Changeset detectedLatest commit: 0660137 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some notes, mostly about version choices. None of these are blocking, LGTM otherwise :)
Co-authored-by: Tierney Cyren <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. But left minor comments.
Work Included:
lerna
for bootstrapping and task running in favor ofnpm workspaces
lerna
in favor ofchangesets
for versioningKnown Issues:
TherequireFromProject.test.ts
files are currently partially disabled becausenpm workspaces
hoists thetwilio
dependency to the rootnode_modules
folder instead of having multiple instances. This results in the test no longer working. Virual mocks might be an alternative but needs validation.`skipLibCheck
is currently enabled in thetsconfig.base.json
because@types/inquirer
andexeca
were throwing issues --> Moved to Turn offskipLibCheck
in tsconfig #451useUnknownInCatchVariables
is currently disabled as it was a breaking change between TypeScript 3.x and 4.4 and requires code changes. --> Moved to Re-enableuseUnknownInCatchVariables
#452Netlify build is currently failing.Contributing to Twilio